KarmaGYZ commented on code in PR #22938:
URL: https://github.com/apache/flink/pull/22938#discussion_r1363506946
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/FunctionCatalog.java:
##########
@@ -269,6 +279,7 @@ public boolean dropCatalogFunction(
"Could not drop catalog function '%s'.",
identifier.asSummaryString()),
t);
}
+
Review Comment:
nit: redundant line.
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/FunctionCatalog.java:
##########
@@ -131,10 +132,17 @@ public boolean dropTemporarySystemFunction(String name,
boolean ignoreIfNotExist
"Could not drop temporary system function. A
function named '%s' doesn't exist.",
name));
}
+ unregisterFunctionJarResources(function);
return function != null;
}
+ private void unregisterFunctionJarResources(CatalogFunction function) {
Review Comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
