XComp commented on PR #23528: URL: https://github.com/apache/flink/pull/23528#issuecomment-1768147345
I noticed that have created a separate PR #23497 for the minikube download. :+1: Could you cover the `kubectl` in this PR then? On another note: @afedulov has a good point on adding retry logic. You could use `retry_times` (see [apache/flink:flink-end-to-end-tests/test-scripts/common.sh:883ff](https://github.com/apache/flink/blob/d8630cb5db0608a630de95df0dd1d0c9f0b56aa2/flink-end-to-end-tests/test-scripts/common.sh#L883)) instead of reimplementing the logic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
