TanYuxin-tyx commented on code in PR #21620:
URL: https://github.com/apache/flink/pull/21620#discussion_r1065922534
##########
flink-core/src/main/java/org/apache/flink/configuration/NettyShuffleEnvironmentOptions.java:
##########
@@ -213,6 +214,7 @@ public class NettyShuffleEnvironmentOptions {
* Number of extra network buffers to use for each outgoing/incoming gate
(result
* partition/input gate).
*/
+ @Deprecated
Review Comment:
OK, removed.
##########
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/NettyShuffleEnvironmentConfiguration.java:
##########
@@ -282,6 +300,17 @@ public static NettyShuffleEnvironmentConfiguration
fromConfiguration(
configuration.getInteger(
NettyShuffleEnvironmentOptions.NETWORK_EXTRA_BUFFERS_PER_GATE);
+ boolean isRequiredMaxBuffersConfigured =
+ configuration.contains(
+
NettyShuffleEnvironmentOptions.NETWORK_READ_BUFFERS_REQUIRED_PER_GATE_MAX);
+
+ int requiredMaxBuffersPerGate =
+ isRequiredMaxBuffersConfigured
+ ? configuration.getInteger(
+ NettyShuffleEnvironmentOptions
+
.NETWORK_READ_BUFFERS_REQUIRED_PER_GATE_MAX)
+ : -1;
Review Comment:
OK, use getOptional instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
