XComp commented on code in PR #683:
URL: https://github.com/apache/flink-web/pull/683#discussion_r1363833891
##########
content/q/gradle-quickstart.sh:
##########
@@ -46,6 +46,9 @@ defaultFlinkVersion="${1:-1.17.0}"
# passes the scala version prefixed with a _, e.g.: _2.12
scalaBinaryVersionFromCmdArg="${2/_/}"
defaultScalaBinaryVersion="${scalaBinaryVersionFromCmdArg:-2.12}"
+defaultJavaVersion="1.8"
Review Comment:
It would be nice to have all the variable in a single place. We could extend
the list that's already present in `docs/config.toml` and use a basic awk
command to extract the corresponding values, e.g. `awk -F'"'
'/FlinkStableVersion = "/{print $2}' docs/config.toml`. WDYT?
```bash
function extract_parameter() {
if [[ "$#" != 1 ]]; then
echo "Fatal error: No parameter or too many parameter passed: $@"
exit 1;
fi
awk -F'"' '/'$1' = "/{print $2}' docs/config.toml
}
```
##########
content/q/gradle-quickstart.sh:
##########
Review Comment:
We should adapt the scripts in `_include/q/`, instead. `content/q` is going
to be overwritten by the `finalizeDocBuild` in `build.sh` which calls the
`finalizeDocBuild` function defined in
[_utils.sh](https://github.com/apache/flink-web/blob/1bd371b2c01dd89ee9d69302aca65b1ebfd4dc81/_utils.sh#L27).
Sorry, that was my bad. I didn't check this when writing the description of
FLINK-30768.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
