XComp commented on code in PR #23497:
URL: https://github.com/apache/flink/pull/23497#discussion_r1366857711
##########
flink-end-to-end-tests/test-scripts/common_kubernetes.sh:
##########
@@ -48,10 +48,15 @@ function setup_kubernetes_for_linux {
sudo rm "$(which minikube)"
fi
+ # Retry loop download minikube.
if ! [ -x "$(command -v minikube)" ]; then
echo "Installing minikube $MINIKUBE_VERSION ..."
- curl -Lo minikube
https://storage.googleapis.com/minikube/releases/$MINIKUBE_VERSION/minikube-linux-$arch
&& \
- chmod +x minikube && sudo mv minikube /usr/bin/minikube
+
download_minikube_url="https://storage.googleapis.com/minikube/releases/$MINIKUBE_VERSION/minikube-linux-$arch";
+ if ! retry_times ${MINIKUBE_START_RETRIES} ${MINIKUBE_START_BACKOFF}
"curl -Lo minikube ${download_minikube_url}"; then
Review Comment:
have you tried the loop? Looks like curl doesn't return an error code in
case of a failure. :thinking: hint: `--fail` might be what we want according to
`man curl`
##########
flink-end-to-end-tests/test-scripts/common_kubernetes.sh:
##########
@@ -48,10 +48,15 @@ function setup_kubernetes_for_linux {
sudo rm "$(which minikube)"
fi
+ # Retry loop download minikube.
Review Comment:
This comment doesn't add any additional value. The code below makes it quite
clear that retries are done. I guess we can remove the comment again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
