echauchot commented on PR #23: URL: https://github.com/apache/flink-connector-shared-utils/pull/23#issuecomment-1775394910
> Generally speaking I'm not too fond of a general "turn some things off" switch. I get the idea and benefits it would bring, but IMO we should be very explicit as to what checks have been disabled. Because of that I'd rather see a dedicated skip-archunit-tests parameter. This is what I wanted to do at first but as you said in a slack discussion about archunit tests > We could actually roll this into the run_dependency_convergence option because it has fundamentally the same cause. I merged the two. But it seems I misunderstood what you meant. I actually also prefer to keep them separated. So, no problem, I'll make them separated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
