1996fanrui commented on code in PR #686:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1369706833
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java:
##########
@@ -151,6 +151,36 @@ private static ConfigOptions.OptionBuilder
autoScalerConfig(String key) {
.withDescription(
"Lag threshold which will prevent unnecessary
scalings while removing the pending messages responsible for the lag.");
+ public static final ConfigOption<Duration>
OBSERVE_TRUE_PROCESSING_RATE_LAG_THRESHOLD =
+ autoScalerConfig("observed-true-processing-rate.lag-threshold")
Review Comment:
Currently, the `observed-true-processing-rate` just supports source, how
about updating the `observed-true-processing-rate` to `source-fetch-rate`? I'm
not sure whether the `source-fetch-rate` is more clear.
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java:
##########
@@ -151,6 +151,36 @@ private static ConfigOptions.OptionBuilder
autoScalerConfig(String key) {
.withDescription(
"Lag threshold which will prevent unnecessary
scalings while removing the pending messages responsible for the lag.");
+ public static final ConfigOption<Duration>
OBSERVE_TRUE_PROCESSING_RATE_LAG_THRESHOLD =
+ autoScalerConfig("observed-true-processing-rate.lag-threshold")
+ .durationType()
+ .defaultValue(Duration.ofSeconds(30))
+ .withDeprecatedKeys(
+ deprecatedOperatorConfigKey(
+
"observed-true-processing-rate.lag-threshold"))
Review Comment:
These options are introduced in this PR, these deprecated keys aren't
necessary.
##########
flink-autoscaler/src/test/java/org/apache/flink/autoscaler/JobVertexScalerTest.java:
##########
@@ -75,6 +75,7 @@ public void setup() {
@Test
public void testParallelismScaling() {
+ System.out.println("" + (-2 & 0x7FFFFFFF));
Review Comment:
Is it the `left-over` during developing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
