zhu-mingye commented on code in PR #62:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/62#discussion_r1372463440
##########
flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticSearchInputFormatBase.java:
##########
@@ -0,0 +1,227 @@
+package org.apache.flink.streaming.connectors.elasticsearch;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.api.common.io.LocatableInputSplitAssigner;
+import org.apache.flink.api.common.io.RichInputFormat;
+import org.apache.flink.api.common.io.statistics.BaseStatistics;
+import org.apache.flink.api.common.serialization.DeserializationSchema;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.java.tuple.Tuple2;
+import org.apache.flink.api.java.typeutils.ResultTypeQueryable;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.core.io.InputSplitAssigner;
+
+import org.elasticsearch.action.search.SearchRequest;
+import org.elasticsearch.action.search.SearchScrollRequest;
+import org.elasticsearch.common.Strings;
+import org.elasticsearch.common.unit.TimeValue;
+import org.elasticsearch.index.query.QueryBuilder;
+import org.elasticsearch.index.query.QueryBuilders;
+import org.elasticsearch.search.Scroll;
+import org.elasticsearch.search.builder.SearchSourceBuilder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.HashMap;
+import java.util.Map;
+
+import static
org.apache.flink.shaded.curator5.com.google.common.base.Preconditions.checkNotNull;
+
+@Internal
+public class ElasticSearchInputFormatBase<T, C extends AutoCloseable>
+ extends RichInputFormat<T, ElasticsearchInputSplit> implements
ResultTypeQueryable<T> {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(ElasticSearchInputFormatBase.class);
+ private static final long serialVersionUID = 1L;
+ private final DeserializationSchema<T> deserializationSchema;
Review Comment:
下文中使用时 为空 需要再 open 中` deserializationSchema.open(null);`
##########
flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticSearchInputFormatBase.java:
##########
@@ -0,0 +1,227 @@
+package org.apache.flink.streaming.connectors.elasticsearch;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.api.common.io.LocatableInputSplitAssigner;
+import org.apache.flink.api.common.io.RichInputFormat;
+import org.apache.flink.api.common.io.statistics.BaseStatistics;
+import org.apache.flink.api.common.serialization.DeserializationSchema;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.java.tuple.Tuple2;
+import org.apache.flink.api.java.typeutils.ResultTypeQueryable;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.core.io.InputSplitAssigner;
+
+import org.elasticsearch.action.search.SearchRequest;
+import org.elasticsearch.action.search.SearchScrollRequest;
+import org.elasticsearch.common.Strings;
+import org.elasticsearch.common.unit.TimeValue;
+import org.elasticsearch.index.query.QueryBuilder;
+import org.elasticsearch.index.query.QueryBuilders;
+import org.elasticsearch.search.Scroll;
+import org.elasticsearch.search.builder.SearchSourceBuilder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.HashMap;
+import java.util.Map;
+
+import static
org.apache.flink.shaded.curator5.com.google.common.base.Preconditions.checkNotNull;
+
+@Internal
+public class ElasticSearchInputFormatBase<T, C extends AutoCloseable>
+ extends RichInputFormat<T, ElasticsearchInputSplit> implements
ResultTypeQueryable<T> {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(ElasticSearchInputFormatBase.class);
+ private static final long serialVersionUID = 1L;
+ private final DeserializationSchema<T> deserializationSchema;
Review Comment:
下文中使用时 为空 需要再 open 中` deserializationSchema.open(null);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
