twalthr commented on code in PR #23601:
URL: https://github.com/apache/flink/pull/23601#discussion_r1373335550
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/factories/TestValuesRuntimeFunctions.java:
##########
@@ -522,11 +540,13 @@ public void invoke(RowData value, Context context) throws
Exception {
synchronized (LOCK) {
localRawResult.add(row);
if (kind == RowKind.INSERT || kind == RowKind.UPDATE_AFTER) {
- row.setKind(RowKind.INSERT);
- localRetractResult.add(row);
+ final Row retractRow = Row.copy(row);
Review Comment:
deduplicate code and only copy and set kind at a single location
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
