XComp commented on code in PR #683:
URL: https://github.com/apache/flink-web/pull/683#discussion_r1374515494
##########
_include/q/quickstart-scala.sh:
##########
@@ -18,13 +18,16 @@
# limitations under the License.
################################################################################
+source "$(dirname "$0")"/_utils.sh
PACKAGE=quickstart
+defaultFlinkVersion="$(extract_parameter 'FlinkStableVersion')"
+
mvn archetype:generate
\
-DarchetypeGroupId=org.apache.flink \
-DarchetypeArtifactId=flink-quickstart-scala \
- -DarchetypeVersion=${1:-1.17.0}
\
Review Comment:
I don't know why it didn't occur to me before but `./quickstart-scala.sh` is
failing since 1.17. This is because we removed scala support in 1.17. I created
FLINK-33383 to cover this issue.
##########
_include/q/_utils.sh:
##########
@@ -0,0 +1,41 @@
+#!/usr/bin/env bash
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+SCRIPT_DIR=$(cd $(dirname "${BASH_SOURCE[0]}") && pwd)
+CONFIG_DIR="${SCRIPT_DIR}/../../docs/config.toml"
+
+export TOP_PID=$$
Review Comment:
You missed the renaming of the variable. I'm not sure what TOP stands for in
this context. :thinking: Alternatively, you can replace "TOP" with the long
version of this acronym.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
