leonardBang commented on code in PR #23593:
URL: https://github.com/apache/flink/pull/23593#discussion_r1375390240
##########
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/hybrid/HybridSourceSplitEnumerator.java:
##########
@@ -304,6 +304,7 @@ public Object getPreviousEnumerator() {
LOG.info("Starting enumerator for sourceIndex={}", currentSourceIndex);
context.setIsProcessingBacklog(currentSourceIndex < sources.size() -
1);
currentEnumerator.start();
+ finishedReaders.clear();
Review Comment:
`finishedReaders` is used to track readers that have finished processing
for current enumerator, but the ` currentEnumerator` here has been switched to
next enumerator and the next enumerator has been started which may lead to some
potential issue, I think we should add the cleanup piece following line 251,
the resource cleanup should follow its serving enumerator, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
