Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2754#discussion_r87017118
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/messages/checkpoint/DeclineCheckpoint.java
---
@@ -31,44 +34,44 @@
private static final long serialVersionUID = 2094094662279578953L;
- /** The timestamp associated with the checkpoint */
- private final long timestamp;
+ /** The reason why the checkpoint was declined */
+ private final Throwable reason;
- public DeclineCheckpoint(JobID job, ExecutionAttemptID taskExecutionId,
long checkpointId, long timestamp) {
- super(job, taskExecutionId, checkpointId);
- this.timestamp = timestamp;
+ public DeclineCheckpoint(JobID job, ExecutionAttemptID taskExecutionId,
long checkpointId) {
+ this(job, taskExecutionId, checkpointId, null);
}
- //
--------------------------------------------------------------------------------------------
-
- public long getTimestamp() {
- return timestamp;
+ public DeclineCheckpoint(JobID job, ExecutionAttemptID taskExecutionId,
long checkpointId, Throwable reason) {
+ super(job, taskExecutionId, checkpointId);
+
+ if (reason == null ||
+ reason.getClass() ==
CheckpointDeclineOnCancellationBarrierException.class ||
--- End diff --
Noticed during backporting: This misses other known exceptions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
