[
https://issues.apache.org/jira/browse/FLINK-4975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15647914#comment-15647914
]
ASF GitHub Bot commented on FLINK-4975:
---------------------------------------
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2754#discussion_r87017118
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/messages/checkpoint/DeclineCheckpoint.java
---
@@ -31,44 +34,44 @@
private static final long serialVersionUID = 2094094662279578953L;
- /** The timestamp associated with the checkpoint */
- private final long timestamp;
+ /** The reason why the checkpoint was declined */
+ private final Throwable reason;
- public DeclineCheckpoint(JobID job, ExecutionAttemptID taskExecutionId,
long checkpointId, long timestamp) {
- super(job, taskExecutionId, checkpointId);
- this.timestamp = timestamp;
+ public DeclineCheckpoint(JobID job, ExecutionAttemptID taskExecutionId,
long checkpointId) {
+ this(job, taskExecutionId, checkpointId, null);
}
- //
--------------------------------------------------------------------------------------------
-
- public long getTimestamp() {
- return timestamp;
+ public DeclineCheckpoint(JobID job, ExecutionAttemptID taskExecutionId,
long checkpointId, Throwable reason) {
+ super(job, taskExecutionId, checkpointId);
+
+ if (reason == null ||
+ reason.getClass() ==
CheckpointDeclineOnCancellationBarrierException.class ||
--- End diff --
Noticed during backporting: This misses other known exceptions
> Add a limit for how much data may be buffered during checkpoint alignment
> -------------------------------------------------------------------------
>
> Key: FLINK-4975
> URL: https://issues.apache.org/jira/browse/FLINK-4975
> Project: Flink
> Issue Type: Improvement
> Components: State Backends, Checkpointing
> Affects Versions: 1.1.3
> Reporter: Stephan Ewen
> Assignee: Stephan Ewen
> Fix For: 1.2.0, 1.1.4
>
>
> During checkpoint alignment, data may be buffered/spilled.
> We should introduce an upper limit for the spilled data volume. After
> exceeding that limit, the checkpoint alignment should abort and the
> checkpoint be canceled.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
