TanYuxin-tyx commented on PR #64: URL: https://github.com/apache/flink-connector-kafka/pull/64#issuecomment-1789985229
@MartijnVisser Thanks. It's my fault to use the wrong target branch. I have updated the target branch to v3.0. The reason why it can fix the incorrect -1.18 display is that the version number is derived from the following URL: https://github.com/apache/flink/blob/dc86179e4626ff9efacc637b85a487dd16869e05/docs/layouts/shortcodes/connector_artifact.html#L26. The original code is `connector_artifact flink-connector-kafka 3.0.0`. However, this code fails to assist Flink shortcode (flink/docs/layouts/shortcodes/connector_artifact.html) in constructing the correct version number due to the following two lines: ``` {{ $connector := index .Site.Data $name }} {{ $version := $connector.version }} ``` (Here $name is from the second field of the args, so it is 3.0.0, and .Site.Data cannot be found.) By modifying it to `connector_artifact flink-connector-kafka kafka`, it becomes capable of generating the correct version based on `$connector.version` from the .Site.Data of `themes/connectors/data/kafka.yml`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
