twalthr commented on code in PR #23655:
URL: https://github.com/apache/flink/pull/23655#discussion_r1381585785
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/delegation/StreamPlanner.scala:
##########
@@ -190,10 +190,12 @@ class StreamPlanner(
}
new ExecNodeGraphInternalPlan(
- JsonSerdeUtil
- .createObjectWriter(ctx)
- .withDefaultPrettyPrinter()
- .writeValueAsString(execNodeGraph),
+ // ensures that the JSON output is always normalized
+ () =>
+ JsonSerdeUtil
+ .createObjectWriter(ctx)
Review Comment:
the `ctx` is already locked, also instantiating the writer might add some
unnecessary overhead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
