1996fanrui commented on code in PR #698:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/698#discussion_r1381684156
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/event/AutoScalerEventHandler.java:
##########
@@ -32,32 +35,45 @@
import static
org.apache.flink.autoscaler.metrics.ScalingMetric.TRUE_PROCESSING_RATE;
/**
- * Handler for autoscaler events.
+ * Handler for autoscaler events, it logs events by default.
*
* @param <KEY> The job key.
* @param <Context> Instance of JobAutoScalerContext.
*/
@Experimental
-public interface AutoScalerEventHandler<KEY, Context extends
JobAutoScalerContext<KEY>> {
- String SCALING_SUMMARY_ENTRY =
+public class AutoScalerEventHandler<KEY, Context extends
JobAutoScalerContext<KEY>> {
Review Comment:
Both are fine to me, updated the `AutoScalerEventHandler` as an interface
and added a `LoggableEventHandler` as the logging implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
