RocMarshal commented on code in PR #23658:
URL: https://github.com/apache/flink/pull/23658#discussion_r1382341874
##########
flink-core/src/main/java/org/apache/flink/configuration/ClusterOptions.java:
##########
@@ -84,17 +88,47 @@ public class ClusterOptions {
+ "By default it will use 4 * the number
of CPU cores (hardware contexts) that the cluster process has access to. "
+ "Increasing the pool size allows to run
more IO operations concurrently.");
+ /**
+ * @deprecated Please use {@link
TaskManagerOptions#TASK_MANAGER_LOAD_BALANCE_MODE} instead.
+ * Note: The 'taskmanager.load-balance.mode: SLOTS' is equal to
+ * 'cluster.evenly-spread-out-slots: true'. The
'taskmanager.load-balance.mode: NONE' is
+ * equal to 'cluster.evenly-spread-out-slots: false'.
+ */
+ @Deprecated
@Documentation.Section(Documentation.Sections.EXPERT_SCHEDULING)
public static final ConfigOption<Boolean> EVENLY_SPREAD_OUT_SLOTS_STRATEGY
=
- ConfigOptions.key("cluster.evenly-spread-out-slots")
+ ConfigOptions.key(EVENLY_SPREAD_OUT_SLOTS_STRATEGY_KEY)
.booleanType()
.defaultValue(false)
.withDescription(
Description.builder()
.text(
- "Enable the slot spread out
allocation strategy. This strategy tries to spread out "
- + "the slots evenly across
all available %s.",
- code("TaskExecutors"))
+ "Enable the slot spread out
allocation strategy. "
+ + "This strategy tries to
spread out "
+ + "the slots evenly across
all available %s. "
+ + "Note: The configuration
item is deprecated. "
+ + "Please use '%s'
instead. "
+ + "The '%s: %s' is equal
to '%s: %s'. "
+ + "The '%s: %s' is equal
to '%s: %s'.",
+ code("TaskExecutors"),
+ code(
+ TaskManagerOptions
+
.TASK_MANAGER_LOAD_BALANCE_MODE
+ .key()),
+ code(
+ TaskManagerOptions
+
.TASK_MANAGER_LOAD_BALANCE_MODE
+ .key()),
+ code("SLOTS"),
+
code(EVENLY_SPREAD_OUT_SLOTS_STRATEGY_KEY),
+ code("true"),
+ code(
+ TaskManagerOptions
+
.TASK_MANAGER_LOAD_BALANCE_MODE
+ .key()),
+ code("NONE"),
+
code(EVENLY_SPREAD_OUT_SLOTS_STRATEGY_KEY),
+ code("false"))
Review Comment:
updated~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
