Zakelly commented on code in PR #23441:
URL: https://github.com/apache/flink/pull/23441#discussion_r1382739665
##########
flink-core/src/main/java/org/apache/flink/api/common/state/ListState.java:
##########
@@ -48,10 +48,13 @@ public interface ListState<T> extends MergingState<T,
Iterable<T>> {
* given list of values. The next time {@link #get()} is called (for the
same state partition)
* the returned state will represent the updated list.
*
- * <p>If null or an empty list is passed in, the state value will be null.
+ * <p>If an empty list is passed in, the state value will be null.
Review Comment:
Agreed. A more unified behaviour makes sense. Let's do this in 2.0.
##########
flink-core/src/main/java/org/apache/flink/api/common/state/AppendingState.java:
##########
@@ -58,10 +58,11 @@ public interface AppendingState<IN, OUT> extends State {
* of values. The next time {@link #get()} is called (for the same state
partition) the returned
* state will represent the updated list.
*
- * <p>If null is passed in, the state value will remain unchanged.
+ * <p>If null is passed in, the behaviour is undefined (implementation
related).
Review Comment:
The current situation is that all implementations are not unified. This
comment describe the current situation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
