[ 
https://issues.apache.org/jira/browse/FLINK-33376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783220#comment-17783220
 ] 

Oleksandr Nitavskyi commented on FLINK-33376:
---------------------------------------------

Thanks for the detailed listing. It sounds reasonable to add configuration in 
public Flink interface for only those options:
* 
[authorization|https://curator.apache.org/apidocs/org/apache/curator/framework/CuratorFrameworkFactory.Builder.html#authorization(java.lang.String,byte%5B%5D)]
* 
[maxCloseWaitMs|https://curator.apache.org/apidocs/org/apache/curator/framework/CuratorFrameworkFactory.Builder.html#maxCloseWaitMs(int)]
* 
[simulatedSessionExpirationPercent|https://curator.apache.org/apidocs/org/apache/curator/framework/CuratorFrameworkFactory.Builder.html#simulatedSessionExpirationPercent(int)]

It also make sense to not touch the 
[compressionProvider|https://curator.apache.org/apidocs/org/apache/curator/framework/CuratorFrameworkFactory.Builder.html#compressionProvider(org.apache.curator.framework.api.CompressionProvider)]
 since Flink doesn't store any BLOB data in zookeeper.

In general it make sense to expose only connection related configuration 
(auth/timeouts) since it depends on the Flink's user environment.


Once we have aligned on the set of the options and the fact that we basically 
would add 3 missing options, we can start the documentation process. Am I right?

> Add AuthInfo config option for Zookeeper configuration
> ------------------------------------------------------
>
>                 Key: FLINK-33376
>                 URL: https://issues.apache.org/jira/browse/FLINK-33376
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Oleksandr Nitavskyi
>            Assignee: Oleksandr Nitavskyi
>            Priority: Major
>
> In certain cases ZooKeeper requires additional Authentication information. 
> For example list of valid [names for 
> ensemble|https://zookeeper.apache.org/doc/r3.8.0/zookeeperAdmin.html#:~:text=for%20secure%20authentication.-,zookeeper.ensembleAuthName,-%3A%20(Java%20system%20property]
>  in order to prevent the accidental connecting to a wrong ensemble.
> Curator allows to add additional AuthInfo object for such configuration. Thus 
> it would be useful to add one more additional Map property which would allow 
> to pass AuthInfo objects during Curator client creation.
> *Acceptance Criteria:* For Flink users it is possible to configure auth info 
> list for Curator framework client.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to