libenchao commented on code in PR #23162:
URL: https://github.com/apache/flink/pull/23162#discussion_r1384342316
##########
flink-formats/flink-protobuf/src/main/java/org/apache/flink/formats/protobuf/PbConstant.java:
##########
@@ -27,4 +27,10 @@ public class PbConstant {
public static final String PB_MAP_KEY_NAME = "key";
public static final String PB_MAP_VALUE_NAME = "value";
public static final String PB_OUTER_CLASS_SUFFIX = "OuterClass";
+ /**
+ * JIT optimizer threshold is 8K, unicode encode one char use 2byte, so
use 3K as
Review Comment:
This is not correct, for ascii chars, there is only 1 byte in unicode
encoding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
