libenchao commented on code in PR #23663:
URL: https://github.com/apache/flink/pull/23663#discussion_r1384455373
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/factories/FactoryUtil.java:
##########
@@ -104,6 +104,15 @@ public final class FactoryUtil {
"Defines the format identifier for encoding data. "
+ "The identifier is used to discover a
suitable format factory.");
+ public static final ConfigOption<Integer> SOURCE_PARALLELISM =
Review Comment:
I prefer to structure the configs to groups (and perhaps keeping
alphabetical order within the group), so this should be put into 'scan.xxx'
group.
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/source/InputFormatProvider.java:
##########
@@ -44,6 +50,29 @@ public boolean isBounded() {
};
}
+ /** Helper method for creating a static provider with a provided source
parallelism. */
+ static InputFormatProvider of(
Review Comment:
Can you change `static InputFormatProvider of(InputFormat<RowData, ?>
inputFormat)`'s implementation to just call this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
