Github user thvasilo commented on the issue:
https://github.com/apache/flink/pull/2542
@gaborhermann Yup the approach taken by the Spark community for testing is
closer to what we would like to have for non-deterministic algorithms, but what
you have implemented now should suffice on the assumption that the ALS
implementation is correct.
@tillrohrmann Initially implemented ALS so I'm not sure how he arrived at
the expected results. It would be a good idea for the future to document how we
generate test data so it's easy to replicate and validate the process. That
should be enough for deterministic algorithms, and for non-deterministic we
should have proxies like measuring the error of reconstruction etc.
I'll take a look at the code again now, and will add comments if I find
something. Otherwise I hope @mbalassi can find some time to review and merge if
no objections come up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
