ferenc-csaky commented on code in PR #23443:
URL: https://github.com/apache/flink/pull/23443#discussion_r1386659760
##########
flink-core/src/main/java/org/apache/flink/api/common/io/FileInputFormat.java:
##########
@@ -157,6 +157,10 @@ protected static InflaterInputStreamFactory<?>
getInflaterInputStreamFactory(
}
}
+ public static Set<String> getSupportedCompressionFormats() {
Review Comment:
I'd mark this `@VisibleForTesting`, because only tests use this function.
##########
flink-core/src/test/java/org/apache/flink/testutils/TestFileUtils.java:
##########
@@ -136,6 +138,26 @@ public static String createTempFileDirExtension(
return f.toURI().toString();
}
+ public static String createTempTextFileDirForAllCompressionFormats(File
tempDir)
Review Comment:
I think instead of bringing the specific `FileInputFormat` into this general
utility, it would be cleaner to pass `Set<String> extensions` as a parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
