jnh5y commented on code in PR #23686:
URL: https://github.com/apache/flink/pull/23686#discussion_r1388205498
##########
flink-table/flink-table-planner/src/test/resources/restore-tests/stream-exec-deduplicate_1/deduplicate-asc-proctime/plan/deduplicate-asc-proctime.json:
##########
@@ -0,0 +1,337 @@
+{
+ "flinkVersion" : "1.19",
+ "nodes" : [ {
+ "id" : 8,
+ "type" : "stream-exec-table-source-scan_1",
+ "scanTableSource" : {
+ "table" : {
+ "identifier" : "`default_catalog`.`default_database`.`MyTable`",
+ "resolvedTable" : {
+ "schema" : {
+ "columns" : [ {
+ "name" : "order_id",
+ "dataType" : "BIGINT"
+ }, {
+ "name" : "user",
+ "dataType" : "VARCHAR(2147483647)"
+ }, {
+ "name" : "product",
+ "dataType" : "VARCHAR(2147483647)"
+ }, {
+ "name" : "order_time",
+ "dataType" : "BIGINT"
+ }, {
+ "name" : "event_time",
+ "kind" : "COMPUTED",
+ "expression" : {
+ "rexNode" : {
+ "kind" : "CALL",
+ "internalName" : "$TO_TIMESTAMP$1",
+ "operands" : [ {
+ "kind" : "CALL",
+ "internalName" : "$FROM_UNIXTIME$1",
+ "operands" : [ {
+ "kind" : "INPUT_REF",
+ "inputIndex" : 3,
+ "type" : "BIGINT"
+ } ],
+ "type" : "VARCHAR(2147483647)"
+ } ],
+ "type" : "TIMESTAMP(3)"
+ },
+ "serializableString" :
"TO_TIMESTAMP(FROM_UNIXTIME(`order_time`))"
+ }
+ }, {
+ "name" : "proctime",
+ "kind" : "COMPUTED",
+ "expression" : {
+ "rexNode" : {
+ "kind" : "CALL",
+ "internalName" : "$PROCTIME$1",
+ "operands" : [ ],
+ "type" : {
+ "type" : "TIMESTAMP_WITH_LOCAL_TIME_ZONE",
+ "nullable" : false,
+ "precision" : 3,
+ "kind" : "PROCTIME"
+ }
+ },
+ "serializableString" : "PROCTIME()"
+ }
+ } ],
+ "watermarkSpecs" : [ ]
+ },
+ "partitionKeys" : [ ]
+ }
+ }
+ },
+ "outputType" : "ROW<`order_id` BIGINT, `user` VARCHAR(2147483647),
`product` VARCHAR(2147483647), `order_time` BIGINT>",
+ "description" : "TableSourceScan(table=[[default_catalog,
default_database, MyTable]], fields=[order_id, user, product, order_time])",
+ "inputProperties" : [ ]
+ }, {
+ "id" : 9,
+ "type" : "stream-exec-calc_1",
+ "projection" : [ {
+ "kind" : "INPUT_REF",
+ "inputIndex" : 0,
+ "type" : "BIGINT"
+ }, {
+ "kind" : "INPUT_REF",
+ "inputIndex" : 1,
+ "type" : "VARCHAR(2147483647)"
+ }, {
+ "kind" : "INPUT_REF",
+ "inputIndex" : 2,
+ "type" : "VARCHAR(2147483647)"
+ }, {
+ "kind" : "INPUT_REF",
+ "inputIndex" : 3,
+ "type" : "BIGINT"
+ }, {
+ "kind" : "CALL",
+ "internalName" : "$PROCTIME$1",
+ "operands" : [ ],
+ "type" : {
+ "type" : "TIMESTAMP_WITH_LOCAL_TIME_ZONE",
+ "nullable" : false,
+ "precision" : 3,
+ "kind" : "PROCTIME"
+ }
+ } ],
+ "condition" : null,
+ "inputProperties" : [ {
+ "requiredDistribution" : {
+ "type" : "UNKNOWN"
+ },
+ "damBehavior" : "PIPELINED",
+ "priority" : 0
+ } ],
+ "outputType" : {
+ "type" : "ROW",
+ "fields" : [ {
+ "name" : "order_id",
+ "fieldType" : "BIGINT"
+ }, {
+ "name" : "user",
+ "fieldType" : "VARCHAR(2147483647)"
+ }, {
+ "name" : "product",
+ "fieldType" : "VARCHAR(2147483647)"
+ }, {
+ "name" : "order_time",
+ "fieldType" : "BIGINT"
+ }, {
+ "name" : "proctime",
+ "fieldType" : {
+ "type" : "TIMESTAMP_WITH_LOCAL_TIME_ZONE",
+ "nullable" : false,
+ "precision" : 3,
+ "kind" : "PROCTIME"
+ }
+ } ]
+ },
+ "description" : "Calc(select=[order_id, user, product, order_time,
PROCTIME() AS proctime])"
+ }, {
+ "id" : 10,
+ "type" : "stream-exec-exchange_1",
+ "inputProperties" : [ {
+ "requiredDistribution" : {
+ "type" : "HASH",
+ "keys" : [ 2 ]
+ },
+ "damBehavior" : "PIPELINED",
+ "priority" : 0
+ } ],
+ "outputType" : {
+ "type" : "ROW",
+ "fields" : [ {
+ "name" : "order_id",
+ "fieldType" : "BIGINT"
+ }, {
+ "name" : "user",
+ "fieldType" : "VARCHAR(2147483647)"
+ }, {
+ "name" : "product",
+ "fieldType" : "VARCHAR(2147483647)"
+ }, {
+ "name" : "order_time",
+ "fieldType" : "BIGINT"
+ }, {
+ "name" : "proctime",
+ "fieldType" : {
+ "type" : "TIMESTAMP_WITH_LOCAL_TIME_ZONE",
+ "nullable" : false,
+ "precision" : 3,
+ "kind" : "PROCTIME"
+ }
+ } ]
+ },
+ "description" : "Exchange(distribution=[hash[product]])"
+ }, {
+ "id" : 11,
+ "type" : "stream-exec-deduplicate_1",
+ "configuration" : {
+ "table.exec.deduplicate.insert-update-after-sensitive-enabled" : "true",
+ "table.exec.deduplicate.mini-batch.compact-changes-enabled" : "false",
+ "table.exec.mini-batch.enabled" : "false",
+ "table.exec.mini-batch.size" : "-1"
+ },
+ "uniqueKeys" : [ 2 ],
+ "isRowtime" : false,
Review Comment:
Here's the new test covering isRowtime being false!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
