gyfora commented on code in PR #23490:
URL: https://github.com/apache/flink/pull/23490#discussion_r1388527803
##########
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoSerializer.java:
##########
@@ -400,21 +444,23 @@ public T deserialize(DataInputView source) throws
IOException {
target = createInstance();
}
- if ((flags & NO_SUBCLASS) != 0) {
+ if (isRecord) {
+ JavaRecordBuilderFactory<T>.JavaRecordBuilder builder =
recordHelper.newBuilder();
Review Comment:
I only add the try catch block where the exception is declared as thrown
(where it’s necessary) it’s not thrown in this code hence no try catch block .
I would remove it if I could :)
##########
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoSerializer.java:
##########
@@ -400,21 +444,23 @@ public T deserialize(DataInputView source) throws
IOException {
target = createInstance();
}
- if ((flags & NO_SUBCLASS) != 0) {
+ if (isRecord) {
+ JavaRecordBuilderFactory<T>.JavaRecordBuilder builder =
recordHelper.newBuilder();
Review Comment:
I only add the try catch block where the exception is declared as thrown
(where it’s necessary) it’s not thrown in this code hence no try catch block .
I would remove it if I could :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
