[ 
https://issues.apache.org/jira/browse/FLINK-33295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784689#comment-17784689
 ] 

Peter Vary commented on FLINK-33295:
------------------------------------

`InternalSinkWriterMetricGroup` is an initial class, so in theory connectors 
should not use it.
 * How much effort would it be to enable the annotation check for the 
connectors?
 * We can expose the `MetricsGroupTestUtils` in a test jar, if we see that the 
connectors would like use it for testing.

Thanks for the heads-up!

 

Peter

> Separate SinkV2 and SinkV1Adapter tests
> ---------------------------------------
>
>                 Key: FLINK-33295
>                 URL: https://issues.apache.org/jira/browse/FLINK-33295
>             Project: Flink
>          Issue Type: Sub-task
>          Components: API / DataStream, Connectors / Common
>            Reporter: Peter Vary
>            Assignee: Peter Vary
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.19.0
>
>
> Current SinkV2 tests are based on the sink generated by the 
> _org.apache.flink.streaming.runtime.operators.sink.TestSink_ test class. This 
> test class does not generate the SinkV2 directly, but generates a SinkV1 and 
> wraps in with a 
> _org.apache.flink.streaming.api.transformations.SinkV1Adapter._ While this 
> tests the SinkV2, but only as it is aligned with SinkV1, and the 
> SinkV1Adapter.
> We should have tests where we create a SinkV2 directly and the functionality 
> is tested without the adapter.
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to