RyanSkraba opened a new pull request, #23696:
URL: https://github.com/apache/flink/pull/23696
## What is the purpose of the change
This is a *very* minor change to avoid depending on the value of the
`FLINK_HOME` environment variable when discovering the value of the gpu
discovery test script (only used while testing).
Before this change, the following error occurs on the command line and IDE
if the `FLINK_HOME` is set:
```
java.io.FileNotFoundException: The gpu discovery script does not exist in
path /opt/asf/flink/src/test/resources/testing-gpu-discovery.sh.
at
org.apache.flink.externalresource.gpu.GPUDriver.<init>(GPUDriver.java:98)
at
org.apache.flink.externalresource.gpu.GPUDriverTest.testGPUDriverWithInvalidAmount(GPUDriverTest.java:64)
```
## Brief change log
During unit tests, use an absolute path to the modules `src/test/resources`
directory instead of a path relative to `FLINK_HOME` (if it exists).
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
