LadyForest commented on code in PR #23620:
URL: https://github.com/apache/flink/pull/23620#discussion_r1390116335
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/FlinkRelOptUtil.scala:
##########
@@ -524,4 +530,219 @@ object FlinkRelOptUtil {
}
}
}
+
+ // ----- The following is mainly copied from RelOptUtil -----
+ // ----- Copied Line: 537 ~ 743 -----
+ // ----- Modified Line: 642 ~ 664 -----
Review Comment:
The modofied line should be 642 ~ 662 after the change
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/alias/ClearJoinHintsWithInvalidPropagationShuttle.java:
##########
@@ -48,19 +49,10 @@
* <p>TODO some node will be attached join hints when parse SqlNode to RelNode
such as Project and
* etc. The join hints on these node can also be cleared.
*/
-public class ClearJoinHintWithInvalidPropagationShuttle extends RelShuttleImpl
{
+public class ClearJoinHintsWithInvalidPropagationShuttle extends
JoinHintsRelShuttle {
Review Comment:
Nit: Do you think it's better to move this class under
package`org.apache.flink.table.planner.hint`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
