1996fanrui commented on code in PR #709:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/709#discussion_r1391029074
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/state/AutoScalerStateStore.java:
##########
@@ -41,23 +40,22 @@ void storeScalingHistory(
Context jobContext, Map<JobVertexID, SortedMap<Instant,
ScalingSummary>> scalingHistory)
throws Exception;
- Optional<Map<JobVertexID, SortedMap<Instant, ScalingSummary>>>
getScalingHistory(
- Context jobContext) throws Exception;
+ Map<JobVertexID, SortedMap<Instant, ScalingSummary>>
getScalingHistory(Context jobContext)
Review Comment:
Could we mark these get interfaces as `@Nonnull`?
It's useful to let other developers know this limitation if they want to
implement new state store. Otherwise, autoscaler will have a series of
NullPointerException.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
