afedulov commented on PR #711:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/711#issuecomment-1811283881
@gyfora I'd like to propose to use this format:
```
scalingTracking: |
---
scalingRecords:
"2023-11-14T20:20:39.250503Z":
endTime: "2023-11-14T20:22:04.360972Z"
"2023-11-14T20:22:04.360972Z":
endTime: "2023-11-14T20:23:39.022220Z"
```
Some reasoning:
- It allows to associate tracked restart time with scaling history, which
could be useful for debugging. Without the start timestamp, this won't be
possible.
- It lays out a data structure that is open for extension. This makes it
trivial to add additional fields if we ever need some other scaling- and not
vertex-scoped data which we currently do not anticipate in the future (the
decision to move it into a different config map in such case is a separate
issue).
- The overhead is pretty minimal.
@mxm, I removed the redundant tracking of the target parallelism from the
`ScalingRecords`. The current implementation completely relies on the
`scalingHistory` for this. I had change the `scaleResource` signature to avoid
fetching the tracking and the history twice (we need both in the
JobAutoScalerImpl now).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
