1996fanrui commented on code in PR #710:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/710#discussion_r1393549254
##########
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/autoscaler/state/KubernetesAutoScalerStateStoreTest.java:
##########
@@ -330,4 +331,42 @@ public void testDiscardInvalidHistory() throws Exception {
ctx,
KubernetesAutoScalerStateStore.SCALING_HISTORY_KEY))
.isEmpty();
}
+
+ @Test
+ public void testDiscardAllState() {
Review Comment:
Hi, this test is accessing `configMapStore` instead of
`KubernetesAutoScalerStateStore`.
Should we test `KubernetesAutoScalerStateStore`? If we test
`configMapStore`, it's better to move this test to `ConfigMapStoreTest`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
