[
https://issues.apache.org/jira/browse/FLINK-27056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786178#comment-17786178
]
Zhanghao Chen edited comment on FLINK-27056 at 11/15/23 5:54 AM:
-----------------------------------------------------------------
[~libenchao] Thanks for your attention here. The option's document is removed
here as the current Flink doc generation scheme will ignore deprecated options.
I'm proposing to add doc for deprecated ones as well in FLINK-33240 but
there're some objections in [Document deprecated options as well-Apache Mail
Archives|https://lists.apache.org/thread/48nt80t9j1n0cko8ztbfd0wccbkzk12w] and
FLINK-30862. Currently, the option doc is just misleading users. I think we can
remove the config now and add it back if needed once we reached consensus on
whether to include doc for deprecated options later. WDYT?
was (Author: zhanghao chen):
[~libenchao] Thanks for your attention here. The option's document is removed
here as the current Flink doc generation scheme will ignore deprecated options.
I'm proposing to add doc for deprecated ones as well in FLINK-33240 but
there're some objections in [Re: [DISCUSS][FLINK-33240] Document deprecated
options as well-Apache Mail
Archives|https://lists.apache.org/thread/48nt80t9j1n0cko8ztbfd0wccbkzk12w] and
[FLINK-30862|https://issues.apache.org/jira/browse/FLINK-30862]. Currently, the
option doc is just misleading users. I think we can remove the config now and
add it back if needed once we reached consensus on whether to include doc for
deprecated options later. WDYT?
> "pipeline.time-characteristic" should be deprecated and have EVENT_TIME as
> default value
> ----------------------------------------------------------------------------------------
>
> Key: FLINK-27056
> URL: https://issues.apache.org/jira/browse/FLINK-27056
> Project: Flink
> Issue Type: Technical Debt
> Components: Runtime / Configuration
> Affects Versions: 1.12.7, 1.13.6, 1.14.4, 1.15.0
> Reporter: Zhanghao Chen
> Priority: Minor
> Labels: auto-deprioritized-major, pull-request-available
>
> *Background*
> # pipeline.time-characteristic is the configuration option used to control
> the time characteristic for all created streams, and has the default value
> _PROCESSING_TIME_ at the point of writing. However, the configuration option
> won't take effect unless it is explicitly set by user as we read it into the
> code by configurtion.getOptional(xx).ifPresent(xx).
> # The default value of _TIME_CHARACTERISTIC_ has been changed from
> _PROCESSING_TIME_ to _EVENT_TIME_ in FLINK-19317 Make EventTime the default
> StreamTimeCharacteristic - ASF JIRA (apache.org)
> # _TIME_CHARACTERISTIC_ and the relevant operations that set or uses it have
> been deprecated in FLINK-19318 Deprecate timeWindow() operations in
> DataStream API - ASF JIRA (apache.org) and FLINK-19319 Deprecate
> StreamExecutionEnvironment.setStreamTimeCharacteristic() and
> TimeCharacteristic - ASF JIRA (apache.org)
> *Proposed Change*
> # {*}{*}pipeline.time-characteristic should be deprecated, just like other
> _TIME_CHARACTERISTIC_ related operations as we no longer want user to set
> this.
> # pipeline.time-characteristic should have the default value of
> {_}EVENT_TIME{_}, to reflect the actual default value in system, and avoid
> misleading users.
> Additionally, I think all configuration options which only take effect when
> it is explicitly set by user (aka those read into the system by
> configurtion.getOptional(xx).ifPresent(xx)), should have no default values.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
