Github user thvasilo commented on a diff in the pull request:
https://github.com/apache/flink/pull/2542#discussion_r87199446
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/recommendation/ALS.scala
---
@@ -273,6 +308,14 @@ object ALS {
val defaultValue: Option[Int] = Some(10)
}
+ case object ImplicitPrefs extends Parameter[Boolean] {
--- End diff --
Can't find a way to comment on line 264/299 but we should take the
opportunity to set the default number of factors to a more reasonable 50, and
add to the docstring and documentation the recommendation:
> we recommend working with the highest number of factors feasible within
computational limitations.
Which comes straight from the iALS paper.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
