snuyanzin commented on code in PR #5:
URL:
https://github.com/apache/flink-connector-hive/pull/5#discussion_r1395670915
##########
.github/workflows/push_pr.yml:
##########
@@ -25,4 +25,4 @@ jobs:
compile_and_test:
uses: apache/flink-connector-shared-utils/.github/workflows/ci.yml@ci_utils
with:
- flink_version: 1.16.0
+ flink_version: 1.19-SNAPSHOT
Review Comment:
yes, with last 2 commits 1.18 is supported.
there could be 2 ways: support it for 1.18.0 first only and then apply
similar approach to adapt updates from 1.19
or support it for both 1.19 and 1.18 like here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
