JingGe commented on code in PR #23758:
URL: https://github.com/apache/flink/pull/23758#discussion_r1400413260
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/CheckpointConfig.java:
##########
@@ -759,9 +765,15 @@ public void setCheckpointStorage(CheckpointStorage
storage) {
* Configures the application to write out checkpoint snapshots to the
configured directory. See
* {@link FileSystemCheckpointStorage} for more details on checkpointing
to a file system.
*
+ * @deprecated The method is marked as deprecated because starting from
Flink 1.19, the usage of
+ * all complex Java objects related to configuration, including their
getter and setter
+ * methods, should be replaced by ConfigOption. In a future major
version of Flink, this
Review Comment:
Thanks for the clarification. Based on the thoughts you shared, does it make
sense to deprecated the constructor at line 145 where a new `CheckpointStorage`
instance is created?
https://github.com/apache/flink/pull/23758/files#diff-3eaac3c43787b48b7015b59d0a2208bf8415bd84d32d4e0289d92cbc6509004bL145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
