snuyanzin commented on code in PR #23751:
URL: https://github.com/apache/flink/pull/23751#discussion_r1400586235
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/batch/sql/DagOptimizationTest.scala:
##########
@@ -235,7 +235,7 @@ class DagOptimizationTest extends TableTestBase {
RelNodeBlockPlanBuilder.TABLE_OPTIMIZER_REUSE_OPTIMIZE_BLOCK_WITH_DIGEST_ENABLED,
Boolean.box(true))
// test with non-deterministic udf
- util.tableEnv.registerFunction("random_udf", new NonDeterministicUdf())
+ util.tableEnv.createTemporarySystemFunction("random_udf", new
NonDeterministicUdf())
Review Comment:
initially I just followed javadoc saying that `registerFunction` should be
replaced by `createTemporarySystemFunction` however agree in this case we could
use `addTemporarySystemFunction`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
