[ 
https://issues.apache.org/jira/browse/FLINK-33610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788613#comment-17788613
 ] 

Jiabao Sun commented on FLINK-33610:
------------------------------------

{code}
java.lang.NullPointerException: Cannot invoke 
"org.apache.flink.runtime.operators.util.CoGroupTaskIterator.close()" because 
"this.coGroupIterator" is null
at 
org.apache.flink.runtime.operators.CoGroupDriver.cleanup(CoGroupDriver.java:185)
at 
org.apache.flink.runtime.operators.testutils.DriverTestBase.testDriverInternal(DriverTestBase.java:270)
at 
org.apache.flink.runtime.operators.testutils.DriverTestBase.testDriver(DriverTestBase.java:195)
at 
org.apache.flink.runtime.operators.CoGroupTaskTest.access$200(CoGroupTaskTest.java:45)
at 
org.apache.flink.runtime.operators.CoGroupTaskTest$3.run(CoGroupTaskTest.java:427)
{code}

CoGroupDriver.cleanup() methods will run out of NPE in the case of concurrent 
calling:

* TaskCancelThread -> cleanup()
* taskRunner -> testDriver() -> testDriverInternal() -> finally cleanup(); 

{code:java}
@Override
public void cleanup() throws Exception {
    if (this.coGroupIterator != null) {
        this.coGroupIterator.close();
        this.coGroupIterator = null;
    }
} {code}

I'm willing to fix this problem.

> CoGroupTaskTest.testCancelCoGroupTaskWhileCoGrouping failed with an 
> AssertionError
> ----------------------------------------------------------------------------------
>
>                 Key: FLINK-33610
>                 URL: https://issues.apache.org/jira/browse/FLINK-33610
>             Project: Flink
>          Issue Type: Bug
>          Components: Runtime / Coordination
>    Affects Versions: 1.19.0
>            Reporter: Matthias Pohl
>            Priority: Major
>              Labels: test-stability
>
> [https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=54741&view=logs&j=675bf62c-8558-587e-2555-dcad13acefb5&t=5878eed3-cc1e-5b12-1ed0-9e7139ce0992&l=7690]
> {code:java}
>  Nov 21 01:07:49 01:07:49.733 [ERROR] Tests run: 18, Failures: 1, Errors: 0, 
> Skipped: 0, Time elapsed: 6.204 s <<< FAILURE! - in 
> org.apache.flink.runtime.operators.CoGroupTaskTest
> Nov 21 01:07:49 01:07:49.733 [ERROR] 
> org.apache.flink.runtime.operators.CoGroupTaskTest.testCancelCoGroupTaskWhileCoGrouping
>   Time elapsed: 1.01 s  <<< FAILURE!
> Nov 21 01:07:49 java.lang.AssertionError: Test threw an exception even though 
> it was properly canceled.
> Nov 21 01:07:49       at 
> org.apache.flink.runtime.operators.CoGroupTaskTest.testCancelCoGroupTaskWhileCoGrouping(CoGroupTaskTest.java:448)
> Nov 21 01:07:49       at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> Nov 21 01:07:49       at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
> Nov 21 01:07:49       at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> Nov 21 01:07:49       at 
> java.base/java.lang.reflect.Method.invoke(Method.java:568)
> [...]{code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to