WencongLiu commented on code in PR #23781:
URL: https://github.com/apache/flink/pull/23781#discussion_r1403013119
##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/tier/disk/DiskIOScheduler.java:
##########
@@ -302,18 +299,23 @@ private void triggerScheduling() {
<= maxRequestedBuffers
&& numRequestedBuffers <
bufferPool.getAverageBuffersPerRequester()) {
isRunning = true;
- ioExecutor.execute(
- () -> {
- try {
- run();
- } catch (Throwable throwable) {
- LOG.error("Failed to read data.", throwable);
- // handle un-expected exception as
unhandledExceptionHandler is not
- // worked for ScheduledExecutorService.
-
FatalExitExceptionHandler.INSTANCE.uncaughtException(
- Thread.currentThread(), throwable);
- }
- });
+ try {
+ ioExecutor.execute(
+ () -> {
+ try {
+ run();
+ } catch (Throwable throwable) {
+ LOG.error("Failed to read data.",
throwable);
+ // handle un-expected exception as
unhandledExceptionHandler is
+ // not
+ // worked for ScheduledExecutorService.
Review Comment:
Sorry for the mistake. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
