XComp commented on code in PR #23764: URL: https://github.com/apache/flink/pull/23764#discussion_r1403255647
########## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/highavailability/KubernetesLeaderElectionHaServices.java: ########## @@ -46,7 +46,6 @@ import java.util.concurrent.Executors; import java.util.concurrent.TimeUnit; -import static org.apache.flink.kubernetes.utils.Constants.LABEL_CONFIGMAP_TYPE_HIGH_AVAILABILITY; Review Comment: hm, I see what you mean. We have treated ConfigMap content as non-public in the past, though (e.g. FLINK-24038 which changed the way the HA data is organized). Having this mentioned in the release notes of FLINK-33598 would be good enough in that case. Another option would be to mark the constants as deprecated and document why they are still lingering around even though they are not really used. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
