snuyanzin commented on code in PR #23796:
URL: https://github.com/apache/flink/pull/23796#discussion_r1404868209
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/harness/TableAggregateHarnessTest.scala:
##########
@@ -161,7 +161,7 @@ class TableAggregateHarnessTest(mode: StateBackendMode)
extends HarnessTestBase(
private def createTableAggregateWithRetract()
: (KeyedOneInputStreamOperatorTestHarness[RowData, RowData, RowData],
Array[LogicalType]) = {
val top3 = new Top3WithRetractInput
- tEnv.registerFunction("top3", top3)
+ tEnv.createTemporarySystemFunction("top3", top3)
Review Comment:
here we can not use
```scala
tEnv.createTemporarySystemFunction("top3", classOf[Top3WithMapView])
```
since `top3` is used in `flatAggregate` below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
