huwh commented on code in PR #23794:
URL: https://github.com/apache/flink/pull/23794#discussion_r1405565272
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java:
##########
@@ -2213,12 +2211,24 @@ public final JobClient executeAsync() throws Exception {
*/
@PublicEvolving
public JobClient executeAsync(String jobName) throws Exception {
- Preconditions.checkNotNull(jobName, "Streaming Job name should not be
null.");
final StreamGraph streamGraph = getStreamGraph();
- streamGraph.setJobName(jobName);
+ setJobNameForJobGraph(streamGraph, jobName);
Review Comment:
IMO, The logic is simple and clear, and there is no need to introduce a new
function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
