whhe commented on code in PR #72:
URL:
https://github.com/apache/flink-connector-jdbc/pull/72#discussion_r1410125605
##########
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/JdbcDialectFactory.java:
##########
@@ -46,4 +46,14 @@ public interface JdbcDialectFactory {
/** @return Creates a new instance of the {@link JdbcDialect}. */
JdbcDialect create();
+
+ /**
+ * Creates a new instance of the {@link JdbcDialect} based on compatible
mode.
+ *
+ * @param compatibleMode the compatible mode of database
+ * @return a new instance of {@link JdbcDialect}
+ */
+ default JdbcDialect create(String compatibleMode) {
+ return create();
Review Comment:
Maybe add a check to fail immediately?
```java
if (StringUtils.isNullOrWhitespaceOnly(compatibleMode)) {
return create();
}
throw new UnsupportedOperationException("Option 'compatible-mode' is not
supported for current dialect factory.");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
