[ 
https://issues.apache.org/jira/browse/FLINK-33679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791458#comment-17791458
 ] 

junzhong qin edited comment on FLINK-33679 at 11/30/23 5:06 AM:
----------------------------------------------------------------

Hi [~masteryhx] , I'm confused about the term 'LEGACY' which is commented as 
'This is the mode in which Flink worked so far.' However, the default restore 
mode is 'NO_CLAIM'. Perhaps the issue title is misleading.


was (Author: easonqin):
Hi [~masteryhx] , I confused with LEGACY which commented as "This is the mode 
in which Flink worked so far." But the default restore mode is "NO_CLAIM".

> RestoreMode uses NO_CLAIM as default instead of LEGACY
> ------------------------------------------------------
>
>                 Key: FLINK-33679
>                 URL: https://issues.apache.org/jira/browse/FLINK-33679
>             Project: Flink
>          Issue Type: Improvement
>          Components: Documentation, Runtime / State Backends
>            Reporter: junzhong qin
>            Priority: Minor
>
> RestoreMode uses NO_CLAIM as default instead of LEGACY.
> {code:java}
> public enum RestoreMode implements DescribedEnum {
>     CLAIM(
>             "Flink will take ownership of the given snapshot. It will clean 
> the"
>                     + " snapshot once it is subsumed by newer ones."),
>     NO_CLAIM(
>             "Flink will not claim ownership of the snapshot files. However it 
> will make sure it"
>                     + " does not depend on any artefacts from the restored 
> snapshot. In order to do that,"
>                     + " Flink will take the first checkpoint as a full one, 
> which means it might"
>                     + " reupload/duplicate files that are part of the 
> restored checkpoint."),
>     LEGACY(
>             "This is the mode in which Flink worked so far. It will not claim 
> ownership of the"
>                     + " snapshot and will not delete the files. However, it 
> can directly depend on"
>                     + " the existence of the files of the restored 
> checkpoint. It might not be safe"
>                     + " to delete checkpoints that were restored in legacy 
> mode ");
>     private final String description;
>     RestoreMode(String description) {
>         this.description = description;
>     }
>     @Override
>     @Internal
>     public InlineElement getDescription() {
>         return text(description);
>     }
>     public static final RestoreMode DEFAULT = NO_CLAIM;
> } {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to