[ 
https://issues.apache.org/jira/browse/FLINK-33731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792696#comment-17792696
 ] 

Zhu Zhu edited comment on FLINK-33731 at 12/4/23 7:46 AM:
----------------------------------------------------------

LGTM. It is a legacy issue. When the new failover logics were introduced, there 
were legacy classes directly in package 
{{org.apache.flink.runtime.executiongraph.failover}}, so the sub-package was 
introduced to avoid mixing them up. 
Now that the legacy failover classes are removed already and it's time to do 
the renaming.


was (Author: zhuzh):
LGTM. It is a legacy issue. When the new failover logics is introduced, were 
legacy classes directly in package 
{{org.apache.flink.runtime.executiongraph.failover}}, so the sub-package was 
introduced to avoid mixing them up. 
Now that the legacy failover classes are removed already and it's time to do 
the renaming.

> failover.flip1 package can be rename to failover
> ------------------------------------------------
>
>                 Key: FLINK-33731
>                 URL: https://issues.apache.org/jira/browse/FLINK-33731
>             Project: Flink
>          Issue Type: Technical Debt
>          Components: Runtime / Coordination
>    Affects Versions: 1.18.0, 1.17.2
>            Reporter: Rui Fan
>            Assignee: Rui Fan
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.19.0
>
>
> Currently, there is a org.apache.flink.runtime.executiongraph.failover.flip1 
> package.
> I propose rename the failover.flip1 to failover, in the other word: removing 
> the flip1. I have 2 reasons:
>  * The naming of the package should be based on business semantics, not FLIP 
> number, and the code under the failover.flip1 package has also many changes 
> after FLIP-1.
>  * All code under the failover.flip1 package are Internal code instead 
> @Public code, so they can be renamed directly.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to