gaborgsomogyi commented on PR #23865:
URL: https://github.com/apache/flink/pull/23865#issuecomment-1838941714
I've had an in-depth look on the compatibility guarantee matrix together
with the deprecation policy and here are my findings:
* The doc basically looks good from content perspective though I think
adding it is not enough. Please see my later bullet points.
* The binary compatibility matrix has a bug. Namely in `Minor release` we
can't provide source compatibility without binary compatibility (according to
the actual source code) because when we do compatibility check then we do both
all the time. I think this must be `guarantee provided` both cases but
explaining under what circumstances. (Please see my last bullet point)
* The most important thing is that the binary compatibility matrix is not
true anymore. Namely:
* Some of the API changes are simply not possible because `japicmp` will
block it (good example is patch releases where public API broken). How is
planned to deal with `japicmp`? Personally I can't find any chapter about this.
* With the new FLIP practically we don't have any kind of hard guarantees
from now on which can be expressed with a simple `true/false` flag. I think the
guarantee matrix would be good to be rephrased to reflect the actual state.
(Basically all the green marks would be good to be explained under what
circumstances are they true). When I would be a user and would see a simple
green mark without conditions then I would think that it's true under any
circumstances but it's not like that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
