Github user iampeter commented on a diff in the pull request:
https://github.com/apache/flink/pull/2457#discussion_r87659296
--- Diff:
flink-runtime-web/web-dashboard/app/scripts/modules/jobs/jobs.dir.coffee ---
@@ -281,7 +281,8 @@ angular.module('flinkApp')
# Otherwise add infos
labelValue += "<h5>" + info + " Node</h5>" if
isSpecialIterationNode(info)
labelValue += "<h5>Parallelism: " + el.parallelism + "</h5>"
unless el.parallelism is ""
- labelValue += "<h5>Operation: " +
shortenString(el.operator_strategy) + "</h5>" unless el.operator is `undefined`
+ if el.operator_strategy
+ labelValue += "<h5>Operation: " +
shortenString(el.operator_strategy) + "</h5>" unless el.operator is `undefined`
--- End diff --
It's fine, but maybe:
```
labelValue += "<h5>Operation: " + shortenString(el.operator_strategy) +
"</h5>" unless !el.operator_strategy || el.operator is `undefined`
```
doesn't really matter much, can be as well as you've put it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
