[ 
https://issues.apache.org/jira/browse/FLINK-24150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793137#comment-17793137
 ] 

chaoran.su commented on FLINK-24150:
------------------------------------

[~surendralilhore] Sorry, this pr couldn't help me, beacause we consider the 
qos of pod, which must confirm the resource requests and limits stay the same. 
The pr of Flink-33609 only modified the limit which I think it's more care 
about resource limit of a job. This issue needs requests and limit stay the 
same and changed by pod template.

> Support to configure cpu resource request and limit in pod template
> -------------------------------------------------------------------
>
>                 Key: FLINK-24150
>                 URL: https://issues.apache.org/jira/browse/FLINK-24150
>             Project: Flink
>          Issue Type: New Feature
>          Components: Deployment / Kubernetes
>            Reporter: Yang Wang
>            Priority: Major
>
> Why Flink needs to overwrite memory resource defined in pod template?
> The major reason is that Flink need to ensure the consistency between Flink 
> configuration
> (\{{taskmanager.memory.process.size}} , {{kubernetes.taskmanager.cpu}}) and 
> pod template resource settings. Since users could specify the total process 
> memory or detailed memory[2], Flink will calculate the pod resource 
> internally.
>  
> For the CPU case the template’s requests/limits should have priority if they 
> are specified. The factor could still be used if the template doesn’t specify 
> anything. The logic could be something like this:
>  # To choose CPU request
>  # Read pod template first
>  # If template doesn’t have anything, read from {{kubernetes.taskmanager.cpu}}
>  # If configuration is not specified, fall back to default
>  # To choose CPU limit
>  # Read from template first
>  # If template doesn’t have anything, apply factor to what was chosen in step 
> 1, where the default factor is 1.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to