fsk119 commented on code in PR #23868:
URL: https://github.com/apache/flink/pull/23868#discussion_r1416572012
##########
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliTableauResultView.java:
##########
@@ -114,6 +108,30 @@ public void displayResults() throws SqlExecutionException {
}
}
+ private void printTerminatedFooter(AtomicInteger receivedRowCount) {
+ final String rowTerm = getRowTerm(receivedRowCount);
Review Comment:
The rowTerm is not used by anyone.
##########
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliTableauResultView.java:
##########
@@ -114,6 +108,30 @@ public void displayResults() throws SqlExecutionException {
}
}
+ private void printTerminatedFooter(AtomicInteger receivedRowCount) {
+ final String rowTerm = getRowTerm(receivedRowCount);
+ if (!resultDescriptor.isPrintQueryTimeCost()) {
+ terminal.writer()
+ .println(
+ "Query terminated, received a total of "
+ + receivedRowCount.get()
+ + " "
+ + getRowTerm(receivedRowCount));
+ } else {
+ String timeCost =
Review Comment:
ditto
##########
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliTableauResultView.java:
##########
@@ -114,6 +108,30 @@ public void displayResults() throws SqlExecutionException {
}
}
+ private void printTerminatedFooter(AtomicInteger receivedRowCount) {
Review Comment:
Could you check the behaviour whether hive/presto prints the time cose when
users cancel the execution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
