1996fanrui commented on code in PR #23247:
URL: https://github.com/apache/flink/pull/23247#discussion_r1418378993
##########
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/failover/ExponentialDelayRestartBackoffTimeStrategyTest.java:
##########
@@ -73,14 +75,14 @@ void testMaxBackoff() throws Exception {
}
@Test
- void testResetBackoff() throws Exception {
+ void testResetBackoff() {
final long initialBackoffMS = 1L;
final long resetBackoffThresholdMS = 8L;
final ManualClock clock = new ManualClock();
final ExponentialDelayRestartBackoffTimeStrategy restartStrategy =
new ExponentialDelayRestartBackoffTimeStrategy(
- clock, initialBackoffMS, 5L, 2.0,
resetBackoffThresholdMS, 0.25);
+ clock, initialBackoffMS, 5L, 2.0,
resetBackoffThresholdMS, 0.25, 100);
Review Comment:
Update `attemptsBeforeResetBackoff` to `Integer.MAX_VALUE` for all tests not
related to `maxAttempts`.
`Integer.MAX_VALUE` makes it easier for other developers to know that
attemptsBeforeResetBackoff does not take effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
