mbalassi commented on code in PR #23876:
URL: https://github.com/apache/flink/pull/23876#discussion_r1419100843


##########
flink-python/pyflink/datastream/connectors/tests/test_pulsar.py:
##########
@@ -253,7 +250,6 @@ def test_pulsar_sink(self):
                 .long_type()
                 .no_default_value()._j_config_option), 100)
 
-    @unittest.skip("Should be moved to pulsar connector repo")

Review Comment:
   Given the rework there is no need to disable the tests anymore. The previous 
implementation broke these tests due to the connector externalization work not 
being fully finished for the Python language binding of the connectors.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to